Dreamweb

By default, Wordpress make a private or protected post title look like this:

(Private) MyBlogEntryTitle

I’ve hacked it to look like this:

MyBlogEntryTitle (Private)

Really simple, really.

The hack is to wp-includes/post-template.php, where I change the get_the_title() function to read:

function get_the_title( $id = 0 ) {
        $post = &get_post($id);

        $title = $post->post_title;

        if ( !is_admin() ) {
                // 2008-08-31, RS, moved Protected and Private text to end of title
                if ( !empty($post->post_password) )
                        $title = sprintf(__('%s (Protected)'), $title);
                else if ( isset($post->post_status) && 'private' == $post->post_status )
                        $title = sprintf(__('%s (Private)'), $title);
        }
        return apply_filters( 'the_title', $title );
}

Yeah, yeah, I know the curly braces should be on their own line but I’m not fixing Wordpress’ code formatting, just its functionality.

Mostly just documenting this so I don’t forget, ’specially as I need to do an upgrade of this blog to 3.6.2.  A little inline documentation goes a long way, though.

The little mood icons that appear at the bottom of each post are powered by Cricket Moods.  There was an issue in the current release (3.6) where when a post was updated the moods were re-added.  So I’d be Hungry & Hungry.  Or, worse, Hungry & Hungry & Hungry.  Even I can’t handle that much hungry.

So I played around with the code.  It seems that if I commented out the “if there are no moods, add the selected moods” line then it worked fine, which would be okay except if there really are no moods then I couldn’t add any…

It seemed to go something like this (very roughly):

if ($current_moods)
{
    // update moods with new selections, if any, or delete if no selections
}
else
{
    // add selected moods, if any
}

Which is all very well except that if there were current moods it still seemed to run the code after the else, which surely it can’t do?!

I played around trying to fix the logic and it still seemed to be doing both if and else of the if-else statement.  Then I was struck by remembering a similar sort of logical issue way back (in C#, I believe).  Not, mind you, where code runs both if and else, but where a logical problem can sometimes be avoided by reviewing what you want to happen and just doing that.

What I want is for the selection to be set.  If I let it go, it always sets what I select, regardless of whether that’s what was “supposed” to happen or not, even if that means duplicating existing moods.  So, simplify the issue.  Delete all moods, then add the selections.  No checks whether this or that exists.  No comparing arrays.  Just delete all, then add all.

Works just fine.

This solution credited to Steve, who gave me the piece of understanding (in that code, way back) that meant I could find a solution even if I couldn’t solve the problem (in the time I was prepared to give this).

Current Mood: Amused